Skip to content

ref(taskbroker): Migrate ingest-profiles devenv to new config format#116758

Merged
untitaker merged 1 commit into
masterfrom
markusunterwaditzer/stream-1093-migrate-devenv-to-new-config-format
Jun 3, 2026
Merged

ref(taskbroker): Migrate ingest-profiles devenv to new config format#116758
untitaker merged 1 commit into
masterfrom
markusunterwaditzer/stream-1093-migrate-devenv-to-new-config-format

Conversation

@untitaker

@untitaker untitaker commented Jun 3, 2026

Copy link
Copy Markdown
Member

See getsentry/taskbroker#667 for details.

Same kafka config migration as the self-hosted change, but for the ingest-profiles taskbroker in devservices. Deprecation warnings land as per getsentry/taskbroker#663

ingest-profiles runs in raw mode, and raw mode now requires an explicit retry topic: raw payloads aren't activations, so retries can't loop back into the profiles topic. Retries now go to the main taskworker topic so the existing taskbroker picks them up instead of running another broker.

Depends on getsentry/taskbroker#668, which wires up per-topic raw mode and enforces the retry-topic requirement. Once that ships, the current devenv config breaks without this change.

Move the ingest-profiles taskbroker to the new kafka_clusters/kafka_topics
format. Raw mode moves onto the profiles topic's per-topic raw block, and a
retry topic is now mandatory for raw topics (raw messages aren't activations,
so retries can't loop back into the raw topic). Retries are routed to the main
taskworker topic so the default taskbroker picks them up instead of requiring
another broker.

Depends on taskbroker #668 (per-topic raw + mandatory-retry validation).

ref STREAM-1093

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@linear-code

linear-code Bot commented Jun 3, 2026

Copy link
Copy Markdown

STREAM-1093

@untitaker untitaker marked this pull request as ready for review June 3, 2026 12:09
@untitaker untitaker requested review from a team as code owners June 3, 2026 12:09
@untitaker untitaker requested a review from a team June 3, 2026 12:09
@untitaker

untitaker commented Jun 3, 2026

Copy link
Copy Markdown
Member Author

note to self: wait until getsentry/taskbroker#668 has been pulled by everybody (just wait 1-2 days from now)

reason: there's fixes for raw mode in there, and devenv uses raw mode

@untitaker

Copy link
Copy Markdown
Member Author

nvm this is fine. profiles consumer isn't used by many.

@untitaker untitaker merged commit 87a3ec0 into master Jun 3, 2026
63 checks passed
@untitaker untitaker deleted the markusunterwaditzer/stream-1093-migrate-devenv-to-new-config-format branch June 3, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants