ref(taskbroker): Migrate ingest-profiles devenv to new config format#116758
Merged
untitaker merged 1 commit intoJun 3, 2026
Merged
Conversation
Move the ingest-profiles taskbroker to the new kafka_clusters/kafka_topics format. Raw mode moves onto the profiles topic's per-topic raw block, and a retry topic is now mandatory for raw topics (raw messages aren't activations, so retries can't loop back into the raw topic). Retries are routed to the main taskworker topic so the default taskbroker picks them up instead of requiring another broker. Depends on taskbroker #668 (per-topic raw + mandatory-retry validation). ref STREAM-1093 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
evanh
approved these changes
Jun 3, 2026
Member
Author
|
note to self: wait until getsentry/taskbroker#668 has been pulled by everybody (just wait 1-2 days from now) reason: there's fixes for raw mode in there, and devenv uses raw mode |
Member
Author
|
nvm this is fine. profiles consumer isn't used by many. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See getsentry/taskbroker#667 for details.
Same kafka config migration as the self-hosted change, but for the
ingest-profilestaskbroker in devservices. Deprecation warnings land as per getsentry/taskbroker#663ingest-profilesruns in raw mode, and raw mode now requires an explicit retry topic: raw payloads aren't activations, so retries can't loop back into theprofilestopic. Retries now go to the maintaskworkertopic so the existing taskbroker picks them up instead of running another broker.Depends on getsentry/taskbroker#668, which wires up per-topic raw mode and enforces the retry-topic requirement. Once that ships, the current devenv config breaks without this change.